-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use clang on travis with Android #652
Conversation
The travis failure is due to the fact that the inline assembly uses thumb-2 instructions. According to this page, we are supposed to use the I'm not sure why it works for gcc, but I suppose that gcc doesn't follow the same system. |
Let's change this PR to use the thumb targets so the CI build step passes. |
Never mind,I don't think that's the right solution. I think I have a fix. Working on it. |
I bet Parity is using a newer version of the NDK and/or clang or whatever and I bet that is the solution here. Any tips on how to get ring's CI to work more like Parity's? |
dd7236f
to
8ced5ce
Compare
8ced5ce
to
7b26072
Compare
Tests seem to pass on travis 🎉 |
Thanks! Merged. |
Follow-up of #633