Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang on travis with Android #652

Merged
merged 2 commits into from
May 18, 2018

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented May 16, 2018

Follow-up of #633

@tomaka
Copy link
Contributor Author

tomaka commented May 16, 2018

The travis failure is due to the fact that the inline assembly uses thumb-2 instructions.

According to this page, we are supposed to use the thumb- targets, which makes sense to me.

I'm not sure why it works for gcc, but I suppose that gcc doesn't follow the same system.
I'm also confused as to how Parity successfully compiles despite the fact that is uses clang and a git version of ring (so no precompiled header).

@coveralls
Copy link

coveralls commented May 16, 2018

Coverage Status

Coverage remained the same at ?% when pulling 7b26072 on tomaka:clang-android-travis into ee13e73 on briansmith:master.

@briansmith
Copy link
Owner

According to this page, we are supposed to use the thumb- targets, which makes sense to me.

Let's change this PR to use the thumb targets so the CI build step passes.

@briansmith
Copy link
Owner

Let's change this PR to use the thumb targets so the CI build step passes.

Never mind,I don't think that's the right solution. I think I have a fix. Working on it.

@briansmith
Copy link
Owner

I'm also confused as to how Parity successfully compiles despite the fact that is uses clang and [...]

I bet Parity is using a newer version of the NDK and/or clang or whatever and I bet that is the solution here. Any tips on how to get ring's CI to work more like Parity's?

@tomaka
Copy link
Contributor Author

tomaka commented May 18, 2018

Tests seem to pass on travis 🎉

@briansmith briansmith merged commit 22a5605 into briansmith:master May 18, 2018
@briansmith
Copy link
Owner

Thanks! Merged.

@tomaka tomaka deleted the clang-android-travis branch May 19, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants